![]() ![]() To the logic for the MoveSelection action).ĥ) Removed another line that calculated the max between 0 and Offset is corrected so it doesn't end up on a negative position (similar Method to find the left most TCO being pasted and make sure that the TrackContentWidget::changePosition on the left resize of sample TCOsīecause it will already be called when movePosition triggers theĤ) Added some logic to the TrackContentWidget::pasteSelection ![]() The label displays the position correctly).ģ) Unrelated to this bug, but removed an unnecessary call to TrackContentObjectView::mouseMoveEvent when dragging a single TCO (andĪdded a line updating the value to the real new position of the TCO so This PR fixes this bug by applying the followingġ) TrackContentObject::movePosition now moves the TCO toĢ) Because of the previous change, I removed the line thatĬalculated the max value between 0 and the new position on There was a bug (already present before this PR) where draggingĪ selection before MidiTime 0 would result in some TCOs being placed on * Fixes bug with dragging to negative positions The existing code had the old style and I ended up replicating it on the other methods. * Fixes code style issues on the parameter nameįixes code style issue on the parameter name of createTCO, where _pos was supposed to be just pos. In those the used code style was kept for consistency). On Track::loadSettings there was a call to saveJournallingState(false) followed immediately by restoreJournallingState() which was deleted because it's redundant (probably a left over from copying the code from pasteSelection?).įixes code style issues on some files (except for ones where the current statements already had a different code style. ![]() That PR adds code to move the TCO to the appropriate position inside the constructor of the classes that didn't have it, fixes the code style on the SampleTrack createTCO method and removes the now unneeded calls to movePosition from source files on src/ and plugins/. That lead to unnecessary calls to TCO->movePosition after creating a TCO in many parts of the codebase (making the argument completely redundant) and even to a bug on the BBEditor, caused by a call to createTCO that expected the position to be set on the constructor (see issue #5673). That method takes a MidiTime position as an argument, but except on the class SampleTrack that argument was ignored. Classes that inherit from "Track", also inherit the createTCO method. ![]()
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |